[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#42010: 28.0.50; "You should byte-compile Gnus" message for natively
From: |
Andrea Corallo |
Subject: |
bug#42010: 28.0.50; "You should byte-compile Gnus" message for natively compiled gnus.el |
Date: |
Tue, 23 Jun 2020 07:48:25 +0000 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Arthur Miller <arthur.miller@live.com> writes:
> Andrea Corallo <akrl@sdf.org> writes:
>
>> Doug Davis <ddavis@ddavis.io> writes:
>>
>>> When running `gnus' with a native compiled Emacs build a message is
>>> reported in the minibuffer "You should byte-compile Gnus" and `sit-for'
>>> is called. I'm not sure what check is possible to see if a function is
>>> natively compiled, but perhaps it should be added to this logic in
>>> gnus.el:
>>>
>>> (unless (byte-code-function-p (symbol-function 'gnus))
>>> (message "You should byte-compile Gnus")
>>> (sit-for 2))
>>
>> I'll admint that added to my undenaiable laziness I probably skiped this
>> for so long cause was giving me a tiny satisfaction :)
>>
>> Should be fixed by:
>>
>> 801e19d0ba * lisp/gnus/gnus.el (gnus): Fix a check to handle native
>> compilation.
>>
>> Thanks for the feedback
>>
>> Andrea
> Just rebuild my Emacs and can confirm it if fixed.
>
> Build time seems to be even faster (on my 67k i7 cpu with -j8 switch).
>
> Awesome, thanks Andrea!
Great, thank you for the testing :)
closing
Andrea
--
akrl@sdf.org