[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#40940: 27.0.91; project-query-replace-regexp stops too early
From: |
Eli Zaretskii |
Subject: |
bug#40940: 27.0.91; project-query-replace-regexp stops too early |
Date: |
Fri, 01 May 2020 09:00:10 +0300 |
> From: Juri Linkov <juri@linkov.net>
> Cc: Eli Zaretskii <eliz@gnu.org>, simenheg@runbox.com,
> monnier@IRO.UMontreal.CA, 40940@debbugs.gnu.org
> Date: Thu, 30 Apr 2020 23:16:04 +0300
>
> >> Also, using downcase is not entirely correct, we should
> >> use isearch-no-upper-case-p instead.
> >
> > I usually like isearch-no-upper-case-p behavior, but here it doesn't fit
> > the docstring, does it? There is no value of CASE-FOLD described that
> > would indicate that the function will be too smart about it.
> >
> > So we'd need to update the docstring that the CASE-FOLD value of t will
> > obey the value of `search-upper-case'. Then we'll consult it as well,
> > like isearch-search does.
>
> Recently we changed hi-lock.el to follow the same logic as
> isearch-no-upper-case-p, so this will make the behavior
> consistent across different packages.
Btw, looking at the other callers of fileloop-initialize-search, don't
get their logic backwards? If the string typed by the user does NOT
include upper-case character, that means the search SHOULD obey the
default value of case-fold-search. Or am I missing something?
- bug#40940: 27.0.91; project-query-replace-regexp stops too early,
Eli Zaretskii <=
- bug#40940: 27.0.91; project-query-replace-regexp stops too early, Eli Zaretskii, 2020/05/01
- bug#40940: 27.0.91; project-query-replace-regexp stops too early, Dmitry Gutov, 2020/05/01
- bug#40940: 27.0.91; project-query-replace-regexp stops too early, Eli Zaretskii, 2020/05/01
- bug#40940: 27.0.91; project-query-replace-regexp stops too early, Dmitry Gutov, 2020/05/01
- bug#40940: 27.0.91; project-query-replace-regexp stops too early, Eli Zaretskii, 2020/05/02
- bug#40940: 27.0.91; project-query-replace-regexp stops too early, Eli Zaretskii, 2020/05/02
- bug#40940: 27.0.91; project-query-replace-regexp stops too early, Dmitry Gutov, 2020/05/02
- bug#40940: 27.0.91; project-query-replace-regexp stops too early, Simen Heggestøyl, 2020/05/03
- bug#40940: 27.0.91; project-query-replace-regexp stops too early, Eli Zaretskii, 2020/05/03
- bug#40940: 27.0.91; project-query-replace-regexp stops too early, Dmitry Gutov, 2020/05/03