[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#36672: 27.0.50; NS build: Creating child frame leads to empty space
From: |
Andrii Kolomoiets |
Subject: |
bug#36672: 27.0.50; NS build: Creating child frame leads to empty space |
Date: |
Tue, 10 Mar 2020 10:42:11 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) |
Alan Third <alan@idiocy.org> writes:
> Thanks! This looks much better than what we had before. No crashes for
> one!
>
> A few nitpicks:
>
>> + BOOL is_fullscreen_transition;
>
> I may be misunderstanding this, but would ‘in_fullscreen_transition’
> be a better name?
OK, renamed.
> Opening braces go on a new line.
Braces style is fixed to match Emacs code style.
> And again. That ‘} else {’ should also be over three lines.
>
>> #if MAC_OS_X_VERSION_MIN_REQUIRED < 1070
>> @@ -7932,9 +7998,14 @@ - (void)toggleFullScreen: (id)sender
>> {
>> #if defined (NS_IMPL_COCOA) && MAC_OS_X_VERSION_MAX_ALLOWED >= 1070
>> #if MAC_OS_X_VERSION_MIN_REQUIRED < 1070
>> - if ([[self window] respondsToSelector: @selector(toggleFullScreen:)])
>> + if ([[self window] respondsToSelector: @selector(toggleFullScreen:)]){
>> #endif
>> [[self window] toggleFullScreen:sender];
>> + // wait for fullscreen animation complete (bug#28496)
>> + [self waitFullScreenTransition];
>> +#endif
>> +#if MAC_OS_X_VERSION_MIN_REQUIRED < 1070
>> + }
>> #endif
>> return;
>> }
>
> Should that final #if #endif not be within the outer #if #endif?
Yes. Fixed.
Thanks!
Please see attached patch. Log message is also provided.
0001-NS-child-frame-in-native-fullscreen.patch
Description: Text Data
- bug#36672: 27.0.50; NS build: Creating child frame leads to empty space, Alan Third, 2020/03/01
- bug#36672: 27.0.50; NS build: Creating child frame leads to empty space,
Andrii Kolomoiets <=
- bug#36672: 27.0.50; NS build: Creating child frame leads to empty space, Alan Third, 2020/03/12
- bug#36672: 27.0.50; NS build: Creating child frame leads to empty space, martin rudalics, 2020/03/13
- bug#36672: 27.0.50; NS build: Creating child frame leads to empty space, Alan Third, 2020/03/13
- bug#36672: 27.0.50; NS build: Creating child frame leads to empty space, martin rudalics, 2020/03/13
- bug#36672: 27.0.50; NS build: Creating child frame leads to empty space, martin rudalics, 2020/03/13
- bug#36672: 27.0.50; NS build: Creating child frame leads to empty space, Alan Third, 2020/03/13
- bug#36672: 27.0.50; NS build: Creating child frame leads to empty space, martin rudalics, 2020/03/14