bug#39902: 28.0.50; Marking in dired with active region

[Drew Adams]

> >> (1) Docstring of `dired-mark' says
> >>   "If the region is active, mark all files in the region."
> >>
> >> However, the file in the last line of the region is never marked, even
> >> if the region spans the whole line of this file.
> >
> > The problem seems to be that movement doesn't
> > put the cursor where you (and `dired-mark')
> > expect - the full lines are not selected.
> 
> This is due to the following code in dired-mark:
> 
>       (dired-mark-files-in-region
>        (progn (goto-char beg) (line-beginning-position))
>        (progn (goto-char end) (line-beginning-position))))))
> 
> It may be that the second use of line-beginning-position is simply a
> mistake, and should be line-end-position (CCing Juri Linkov, who wrote
> that code).  That's what diredp-mark-region-files in the library
> dired+.el uses, which is the inspiration for the dired-mark code
> (see bug#10624).

Indeed.  I looked only at `dired-mark', and saw
that Dired+ doesn't substitute anything different
for that (`m' etc. are still bound to vanilla
`dired-mark').

I agree with you about the bug and proposed fix.