[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#38317: Buffer-local variables don't work as history for read-from-mi
From: |
Lars Ingebrigtsen |
Subject: |
bug#38317: Buffer-local variables don't work as history for read-from-minibuffer |
Date: |
Wed, 27 Nov 2019 12:53:23 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Federico Tedin <federicotedin@gmail.com> writes:
> I've tested the following commands with it, using `read-from-minibuffer'
> with a buffer-local HIST:
>
> - previous-history-element (M-p)
> - next-history-element (M-n)
> - previous-matching-history-element (M-r)
> - next-matching-history-element (M-s)
> - isearch-forward (C-s)
> - isearch-backward (C-r)
>
> They've all worked correctly and used only the buffer's local history
> value.
I haven't tested the code, but it makes sense to me. I do wonder
whether there are any instances of the variables that are local to the
minibuffer... but I guess that's unlikely?
> +** 'read-from-minibuffer' now works with buffer-local history variables
> +The HIST argument of 'read-from-minibuffer' now works correctly with
> +buffer-local variables. This means that different buffers can have
> +their own separated input history list if desired.
This should probably be documented in the manual, too?
The patch otherwise looks good to me.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- bug#38317: Buffer-local variables don't work as history for read-from-minibuffer, (continued)
- bug#38317: Buffer-local variables don't work as history for read-from-minibuffer, Lars Ingebrigtsen, 2019/11/22
- bug#38317: Buffer-local variables don't work as history for read-from-minibuffer, Michael Heerdegen, 2019/11/22
- bug#38317: Buffer-local variables don't work as history for read-from-minibuffer, martin rudalics, 2019/11/22
- bug#38317: Buffer-local variables don't work as history for read-from-minibuffer, Lars Ingebrigtsen, 2019/11/23
- bug#38317: Buffer-local variables don't work as history for read-from-minibuffer, Federico Tedin, 2019/11/23
- bug#38317: Buffer-local variables don't work as history for read-from-minibuffer, Federico Tedin, 2019/11/23
- bug#38317: Buffer-local variables don't work as history for read-from-minibuffer, Federico Tedin, 2019/11/26
- bug#38317: Buffer-local variables don't work as history for read-from-minibuffer, Robert Pluim, 2019/11/27
- bug#38317: Buffer-local variables don't work as history for read-from-minibuffer, Drew Adams, 2019/11/27
- bug#38317: Buffer-local variables don't work as history for read-from-minibuffer, Robert Pluim, 2019/11/27
- bug#38317: Buffer-local variables don't work as history for read-from-minibuffer,
Lars Ingebrigtsen <=
- bug#38317: Buffer-local variables don't work as history for read-from-minibuffer, Federico Tedin, 2019/11/27
- bug#38317: Buffer-local variables don't work as history for read-from-minibuffer, Eli Zaretskii, 2019/11/27
- bug#38317: Buffer-local variables don't work as history for read-from-minibuffer, Federico Tedin, 2019/11/27
- bug#38317: Buffer-local variables don't work as history for read-from-minibuffer, Federico Tedin, 2019/11/28
- bug#38317: Buffer-local variables don't work as history for read-from-minibuffer, Richard Stallman, 2019/11/29
- bug#38317: Buffer-local variables don't work as history for read-from-minibuffer, Eli Zaretskii, 2019/11/29
- bug#38317: Buffer-local variables don't work as history for read-from-minibuffer, Federico Tedin, 2019/11/29
- bug#38317: Buffer-local variables don't work as history for read-from-minibuffer, Juri Linkov, 2019/11/27