[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#38282: 26.3; goto-line should not share input history with other com
From: |
Lars Ingebrigtsen |
Subject: |
bug#38282: 26.3; goto-line should not share input history with other commands |
Date: |
Fri, 22 Nov 2019 13:09:06 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Federico Tedin <federicotedin@gmail.com> writes:
> + ;; It would be better to use `goto-line-history' as a HIST
> + ;; parameter to `read-from-minibuffer' (through
> + ;; `read-number'), but using buffer-local variables
> + ;; doesn't work for that purpose. (Bug#38317)
> + (minibuffer-history
> + (buffer-local-value 'goto-line-history (or buffer
> + (current-buffer)))))
I think a per-buffer history for goto-line makes sense, but I was also
wondering whether read-number should have its own separate history, too.
This would, I think, not interoperate well with that (that is, if
`read-number' passes a different variable to read-from-minibuffer than
nil).
So I think a better solution would be to fix the problem with
buffer-local variables not working in read-from-minibuffer first, and
then we could extend read-number with a history parameter instead of
hacking around the problem this way.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- bug#38282: 26.3; goto-line should not share input history with other commands, Federico Tedin, 2019/11/19
- bug#38282: 26.3; goto-line should not share input history with other commands, Lars Ingebrigtsen, 2019/11/21
- bug#38282: 26.3; goto-line should not share input history with other commands, Robert Pluim, 2019/11/21
- bug#38282: 26.3; goto-line should not share input history with other commands, Michael Albinus, 2019/11/21
- bug#38282: 26.3; goto-line should not share input history with other commands, Lars Ingebrigtsen, 2019/11/21
- bug#38282: 26.3; goto-line should not share input history with other commands, Federico Tedin, 2019/11/21
- bug#38282: 26.3; goto-line should not share input history with other commands, Federico Tedin, 2019/11/21
- bug#38282: 26.3; goto-line should not share input history with other commands, Eli Zaretskii, 2019/11/22
- bug#38282: 26.3; goto-line should not share input history with other commands,
Lars Ingebrigtsen <=
- bug#38282: 26.3; goto-line should not share input history with other commands, Federico Tedin, 2019/11/23
- bug#38282: 26.3; goto-line should not share input history with other commands, Lars Ingebrigtsen, 2019/11/27
- bug#38282: 26.3; goto-line should not share input history with other commands, Michael Albinus, 2019/11/22
- bug#38282: 26.3; goto-line should not share input history with other commands, Robert Pluim, 2019/11/22