[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#38284: 27.0.50; [PATCH] Make auth-source-pass-search understand port
From: |
Damien Cassou |
Subject: |
bug#38284: 27.0.50; [PATCH] Make auth-source-pass-search understand port lists |
Date: |
Fri, 22 Nov 2019 09:49:20 +0100 |
Hi João,
João Távora <joaotavora@gmail.com> writes:
>> can you please rename "d" to "domain"?
>
> ok. I do call your attention that it was already the
> single letter n there
yes I saw. This should never have been merged like that. Thank you for
improving the code.
>> Can you please add a unit test covering this new use-case?
>
> No. This is too much work for such a trivial change
I care a lot about the automated testing of the code I write. I won't
try to convince you though. Can you please merge the attached patch with
yours?
--
Damien Cassou
"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill
0001-WIP.patch
Description: Text Data