[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#30990: Should the byte compiler warn about :type mismatches?
From: |
Lars Ingebrigtsen |
Subject: |
bug#30990: Should the byte compiler warn about :type mismatches? |
Date: |
Fri, 11 Oct 2019 07:54:00 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Robert Pluim <rpluim@gmail.com> writes:
> Except that the underlying type is '(repeat ....) so I wonder if this:
>
> (dolist (ext '(".json.gpg" ".gpg" ".json" "") wallet)
> (unless wallet
> (setq w (locate-user-emacs-file (concat "sql-wallet" ext)
> (concat ".sql-wallet" ext)))
> (when (file-exists-p w)
> (setq wallet w))))) ; <= this returns a string
>
> should use (setq wallet (list w)) instead
Indeed. It looks like this is where it's used:
(defun sql-auth-source-search-wallet (wallet product user server database port)
[...]
(let* ((auth-sources wallet)
and auth-source-search assumes that auth-sources is a list of
... things, not a string:
(cl-defun auth-source-search (&rest spec
&key max require create delete
&allow-other-keys)
[...]
(let* ((backends (mapcar #'auth-source-backend-parse auth-sources))
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no