[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#37538: [PATCH] Add docstring for `tags-complete-tags-table-file'.
From: |
Hong Xu |
Subject: |
bug#37538: [PATCH] Add docstring for `tags-complete-tags-table-file'. |
Date: |
Tue, 8 Oct 2019 23:39:08 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 10/8/19 9:21 AM, Lars Ingebrigtsen wrote:
The problem is that `(elisp) Programmed Completion' (at least in Emacs
27) doesn't mention a WHAT parameter at all, so it's unclear what this
refers to.
How about the following change?
diff --git a/doc/lispref/minibuf.texi b/doc/lispref/minibuf.texi
index a9d6e83cf854..73af67ab083f 100644
--- a/doc/lispref/minibuf.texi
+++ b/doc/lispref/minibuf.texi
@@ -1769,7 +1769,8 @@ Programmed Completion
completion functions, which will then let your function do all
the work.
- The completion function should accept three arguments:
+ The completion function should accept three arguments in the
+following order:
@itemize @bullet
@item
diff --git a/lisp/progmodes/etags.el b/lisp/progmodes/etags.el
index 6784894ba87e..d58e2cb2a187 100644
--- a/lisp/progmodes/etags.el
+++ b/lisp/progmodes/etags.el
@@ -1853,8 +1853,8 @@ tags-complete-tags-table-file
"Complete STRING from file names in the current tags table.
The meaning of the arguments are the same as the function form of
COLLECTION as explained in Info node `(elisp) Programmed
-Completion', except that if WHAT does not equal t, it is treated
-as if it were nil."
+Completion', except that if the third argument does not equal t,
+it is treated as if it were nil."
(save-excursion
;; If we need to ask for the tag table, allow that.
(let ((enable-recursive-minibuffers t))
- bug#37538: [PATCH] Add docstring for `tags-complete-tags-table-file'., Lars Ingebrigtsen, 2019/10/07
- bug#37538: [PATCH] Add docstring for `tags-complete-tags-table-file'., Eli Zaretskii, 2019/10/07
- bug#37538: [PATCH] Add docstring for `tags-complete-tags-table-file'., Hong Xu, 2019/10/07
- bug#37538: [PATCH] Add docstring for `tags-complete-tags-table-file'., Lars Ingebrigtsen, 2019/10/08
- bug#37538: [PATCH] Add docstring for `tags-complete-tags-table-file'.,
Hong Xu <=
- bug#37538: [PATCH] Add docstring for `tags-complete-tags-table-file'., Eli Zaretskii, 2019/10/09
- bug#37538: [PATCH] Add docstring for `tags-complete-tags-table-file'., Hong Xu, 2019/10/09
- bug#37538: [PATCH] Add docstring for `tags-complete-tags-table-file'., Eli Zaretskii, 2019/10/10
- bug#37538: [PATCH] Add docstring for `tags-complete-tags-table-file'., Hong Xu, 2019/10/11
- bug#37538: [PATCH] Add docstring for `tags-complete-tags-table-file'., Eli Zaretskii, 2019/10/12
- bug#37538: [PATCH] Add docstring for `tags-complete-tags-table-file'., Hong Xu, 2019/10/12
- bug#37538: [PATCH] Add docstring for `tags-complete-tags-table-file'., Eli Zaretskii, 2019/10/12