[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#37548: Implement sanitation of single-file package long description
From: |
Bruno Félix Rezende Ribeiro |
Subject: |
bug#37548: Implement sanitation of single-file package long description |
Date: |
Tue, 08 Oct 2019 05:36:40 -0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
> Stefan Kangas <stefan@marxist.se> writes:
>
> I noticed something else: There is actually already code duplication
> in package.el -- there is code to strip the commentary section in both
> package--get-description and describe-package-1.
>
> Perhaps it would make sense to look this all over and see how we can do
> better?
I decided to tackle the problem’s root. After figuring out that every
function depending on ‘lm-commentary’ implemented their own ad-hoc
sanitation for the same effect, I changed ‘lm-commentary’ to return a
sanitized string and removed the code/functionality duplication from all
callers.
> I also have two general questions, which are applicable to both your
> recent patches:
>
> 1. It looks likely that this together with your other patch and your
> previous contributions will together amount to more than 15 lines of
> code. That means that you would have to sign Copyright Assignment
> papers for GNU Emacs. I see you're emailing from gnu.org, so I assume
> there are no surprises for you here; I guess Eli can help you sort
> that out if it's not already.
I’ve assigned my copyright for work on Emacs to the FSF already.
> 2. Could you please provide a commit message formatted as a changelog
> entry? Details on this are in the CONTRIBUTE file in the repository.
Please, find it in the patch attached.
0001-Globally-sanitize-single-file-package-long-descripti.patch
Description: Text Data
--
Bruno Félix Rezende Ribeiro (oitofelix) [0x28D618AF]
<http://oitofelix.freeshell.org/>
- bug#37548: Implement sanitation of single-file package long description,
Bruno Félix Rezende Ribeiro <=