[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#37636: 26.1; comint password prompt regexp doesn't handle python twi
From: |
Stefan Kangas |
Subject: |
bug#37636: 26.1; comint password prompt regexp doesn't handle python twine prompting for password |
Date: |
Sun, 6 Oct 2019 03:16:40 +0200 |
Toby Ferguson <toby.h.ferguson@gmail.com> writes:
> When I attempt to execute a command in a bash shell using python the python
> command prompts for a password and that password prompt isn't hidden. In what
> follows I'll replace my real password with the string FARGLE. Here's the
> offending interaction in a bash shell buffer:
>
> (cdp_validator) bash-4.4$ python3 -m twine upload dist/*
> Enter your usErname: toby.h.ferguson
> Enter your password: FARGLE
>
> As you can see, the password isn't hidden at all :-(
>
> Executing the following elisp fixed the problem:
>
> (setq comint-password-prompt-regexp
> (concat comint-password-prompt-regexp
> "\\|^Enter your password:.*"))
>
> The general task here that the python is executing is pretty common:
> uploading a package to PyPi. So I would ask that you add that string as a
> default to the comint-password-prompt-regexp
Thank you for the bug report.
I believe that this has already been fixed on the current master
branch. When I added the string "Enter your password: " to the test
suite for comint-password-prompt-regexp, the test passed with no
further changes.
You could try building the current master branch to verify that this
works for you. I've attached a patch containing an addition to the
test suite which I'll push to the master branch.
Best regards,
Stefan Kangas
0001-Add-new-example-to-comint-password-prompt-tests.patch
Description: Text Data