[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#36618: 26.2; Misnamed `*-hooks' variables
From: |
Drew Adams |
Subject: |
bug#36618: 26.2; Misnamed `*-hooks' variables |
Date: |
Sat, 13 Jul 2019 10:23:23 -0700 (PDT) |
> > The following variable names end in `-hooks', instead of `-hook' or
> > `-functions' (there may be more - just noticed these in one of my
> > sessions):
> >
> > bookmark-exit-hooks (OBS)
>
> As you say, there's nothing to be done about obsolete -hooks variables.
>
> > delay-mode-hooks (Bool)
>
> These bool variables have logical names -- they say whether to do
> something or other about the hooks, so I don't think they should change
> names.
>
> > delayed-mode-hooks XXX
>
> That's not really a -hook variable, but list of hook variables to run,
> so it's fine:
>
> (defvar-local delayed-mode-hooks nil
> "List of delayed mode hooks waiting to be run.")
>
> > ediff-before-session-group-setup-hooks XXX
>
> This is a variable that's never used, apparently? I'll just mark it as
> obsolete.
>
> > recentf-used-hooks XXX
>
> It's a list of hooks, not a hook, so has a correct name.
>
> > unload-feature-special-hooks (aliased)
>
> Same.
>
> Nothing to be done for the rest; closing.
IOW, "won't fix".
Lists of hooks are not hooks. Boolean variables that
control behavior of hooks are not hooks.
A user looking for hooks will fall upon these misleading
names of non-hooks using completion (e.g. substring).
We can help her or mislead her. Currently we throw noise
in her face. Not much noise - there are only a few such
anomalies cited here.