bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#35353: 26.2; Buffer *xref*: (1) hard-coded mouse-1, (2) major mode n


From: Dmitry Gutov
Subject: bug#35353: 26.2; Buffer *xref*: (1) hard-coded mouse-1, (2) major mode name
Date: Mon, 22 Apr 2019 12:24:11 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1

On 21.04.2019 16:27, Drew Adams wrote:
Please respect `mouse-1-click-follows-link'.

Please contrast what, say, `compile.el' does, which is
simple and Emacs-conventional:

  (define-key map [mouse-2]     'compile-goto-error)
  (define-key map [follow-link] 'mouse-face)

See (elisp) `Key Binding Conventions':

  Many special major modes, like Dired, Info, Compilation,
  and Occur, are designed to handle read-only text that
  contains "hyper-links".

  Such a major mode should redefine 'mouse-2' and <RET> to
                    ^^^^^^^^^^^^^^^^^^^^^^^^^
  follow the links.  It should also set up a 'follow-link'
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  condition, so that the link obeys 'mouse-1-click-follows-link'.

  *Note Clickable Text::.  *Note Buttons::, for an easy
  method of implementing such clickable links.

Each core Emacs developer who defines a major mode with
clickable links should be familiar with and respect this
convention.

Thank you for the report.

It's not hard to fix, but it seems to do that we'll have to give mouse-2 a different binding from what it has now. Which is also a breaking change (in Xref).

I'd like to let someone else decide whether this is worth it.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]