bug#34294: 27.0.50; flymake-start-on-save-buffer has no effect

[Juri Linkov]

> Could you please also push an additional patch that fixes
> a race condition in flymake.  The problem is that currently
> flymake starts even when flymake-mode is disabled.

More problems: when an error is shown in the tooltip, currently there is
no way to copy a solution sometimes provided as part of the tooltip text.

This fix allows the tooltip text to be added to the *Messages* buffer:

@@ -640,10 +644,11 @@ flymake--highlight-line
       (default-maybe 'help-echo
         (lambda (window _ov pos)
           (with-selected-window window
-            (mapconcat
-             #'flymake--diag-text
-             (flymake-diagnostics pos)
-             "\n"))))
+            (let ((inhibit-message t))
+              (message "%s" (mapconcat
+                             #'flymake--diag-text
+                             (flymake-diagnostics pos)
+                             "\n"))))))
       (default-maybe 'severity (warning-numeric-level :error))
       (default-maybe 'priority (+ 100 (overlay-get ov 'severity))))
     ;; Some properties can't be overridden.