bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#34776: Acknowledgement (27.0.50; Some questions about choose-complet


From: Noam Postavsky
Subject: bug#34776: Acknowledgement (27.0.50; Some questions about choose-completion-string-functions)
Date: Tue, 09 Apr 2019 20:03:17 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux)

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> So never mind! But I'd still like to add something like the attached, as
> functions following the current docstring will raise an error.
>
> Eric
>
> diff --git a/lisp/simple.el b/lisp/simple.el
> index d4ae5ebb1f..0274bdb459 100644
> --- a/lisp/simple.el
> +++ b/lisp/simple.el
> @@ -8188,6 +8188,9 @@ choose-completion-string-functions
>  BUFFER - the buffer in which the choice should be inserted,
>  BASE-POSITION - where to insert the completion.
>  
> +Functions should also accept and ignore a potential fourth
> +argument, passed for backwards compatibility.
> +

Looks good to me.  And it can go to emacs-26 since it's a doc fix.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]