bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#32676: [PATCH] Add option to highlight the 'next-error' error messag


From: Juri Linkov
Subject: bug#32676: [PATCH] Add option to highlight the 'next-error' error message
Date: Mon, 08 Apr 2019 22:36:38 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu)

> I'd like to know if this patch is still being considered?

Why not?  Your patch provides a helpful feature.  I see only 2 problems
with its latest version:

1. compilation-current-error should be generalized not to be too
   compilation-specific;

2. next-error-hook should not be used for core features,
   you could call next-error-message-highlight directly
   from next-error-found.

PS: maybe a better name for defcustom would be next-error-message-highlight,
    not next-error-message-highlight-p, to be more future-proof,
    for the case when someone might want to add more choices later
    (e.g. fringe, timers, etc.)





reply via email to

[Prev in Thread] Current Thread [Next in Thread]