bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#35123: [PATCH] Use lexical-binding in bug-reference


From: Basil L. Contovounesios
Subject: bug#35123: [PATCH] Use lexical-binding in bug-reference
Date: Wed, 03 Apr 2019 17:42:31 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Alex Branham <alex.branham@gmail.com> writes:

> diff --git a/.dir-locals.el b/.dir-locals.el
> index 9cd39920c2..506edfcf73 100644
> --- a/.dir-locals.el
> +++ b/.dir-locals.el
> @@ -1,6 +1,7 @@
>  ((nil . ((tab-width . 8)
>           (sentence-end-double-space . t)
> -         (fill-column . 70)))
> +         (fill-column . 70)
> +         (bug-reference-url-format . "https://debbugs.gnu.org/%s";)))
>   (c-mode . ((c-file-style . "GNU")
>              (c-noise-macro-names . ("INLINE" 
> "ATTRIBUTE_NO_SANITIZE_UNDEFINED" "UNINIT" "CALLBACK" "ALIGN_STACK"))
>              (electric-quote-comment . nil)
> @@ -12,7 +13,6 @@
>                     (log-edit-setup-add-author . t)))
>   (change-log-mode . ((add-log-time-zone-rule . t)
>                    (fill-column . 74)
> -                  (bug-reference-url-format . "https://debbugs.gnu.org/%s";)
>                    (mode . bug-reference)))
>   (diff-mode . ((mode . whitespace)))
>   (emacs-lisp-mode . ((indent-tabs-mode . nil)

While you're at it, why not also change (mode . bug-reference)
to (eval . (bug-reference-mode)) as per the recommended way to enable
minor modes described in (info "(emacs) Specifying File Variables")?

Apart from that, and FWIW, LGTM.

Thanks,

-- 
Basil





reply via email to

[Prev in Thread] Current Thread [Next in Thread]