bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#33225: [debbugs.el] Don't send control message immediately


From: Michael Albinus
Subject: bug#33225: [debbugs.el] Don't send control message immediately
Date: Mon, 01 Apr 2019 09:35:45 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Noam Postavsky <npostavs@gmail.com> writes:

Hi Noam,

> I've updated according to your comments, I'll wait another couple of
> days before pushing in case we can catch any more silly mistakes.

It looks almost good. Still some minor nits :-)

> Regarding making a release, I have in mind next to bring in my commands
> which produce control messages from git commits (both for attaching
> proposed patches from an unpushed commit, and closing from a pushed
> one).  Perhaps you want to wait for that before making a new release?
> (or perhaps just the opposite, not sure what your release policy is)

My release policy is very simple: gut feeling. I have no pending issue
to solve, so we could wait for the release.

I'd prefer if you would commit your changes so far, that we have a
common base, and further patches you'll show are shorter (to review).

> +        ((member message '("unarchive" "unmerge" "noowner"
> +                           "notfixed" "notforwarded"))
> +         (format "%s %d\n" message bugid))

You have (correctly) said, that "notfixed" isn't documented on
debbugs.gnu.org. So I have checked
<https://www.debian.org/Bugs/server-control#notfixed>. "notfixed"
requires also a version number, it should be moved to the handling of

> +        ((member message '("found" "notfound" "fixed"))
> +         (format "%s %d %s\n" message bugid version))

> +@item
> +@kindex @kbd{C}
> +@kbd{C} @tab
> +@code{debbugs-gnu-make-control-message} @*


This shall be {E}

> +@item found
> +@itemx notfound
> +@itemx fixed
> +"found|notfound|fixed 12345 25.1"

Please add notfixed.

Best regards, Michael.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]