[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#34469: 26.1; EWW stops renderring web page on null byte
From: |
Robert Pluim |
Subject: |
bug#34469: 26.1; EWW stops renderring web page on null byte |
Date: |
Wed, 20 Feb 2019 19:48:50 +0100 |
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Robert Pluim <rpluim@gmail.com>
>> Cc: 34469@debbugs.gnu.org, nicholasdrozd@gmail.com
>> Date: Tue, 19 Feb 2019 18:37:26 +0100
>>
>> Since this is all due to a C-ism in the handling of content, Iʼd vote
>> for "\0", although this is inside Emacs, so perhaps "^@" is best.
>
> Either is fine with me.
Since the web page that triggered this was showing C code, Iʼve gone
for the "\0" option.
2019-02-20 Robert Pluim <rpluim@gmail.com>
* lisp/net/eww.el (eww-display-html): Replace NULL characters with
"\0", as libxml can't handle embedded NULLs.
diff --git i/lisp/net/eww.el w/lisp/net/eww.el
index 555b3bd591..06075b1ebd 100644
--- i/lisp/net/eww.el
+++ w/lisp/net/eww.el
@@ -462,10 +462,12 @@ eww-display-html
(condition-case nil
(decode-coding-region (point) (point-max) encode)
(coding-system-error nil))
- (save-excursion
- ;; Remove CRLF before parsing.
- (while (re-search-forward "\r$" nil t)
- (replace-match "" t t)))
+ (save-excursion
+ ;; Remove CRLF and NULL before parsing.
+ (while (re-search-forward "\\(\r$\\)\\|\\(\000\\)" nil t)
+ (replace-match (if (match-beginning 1)
+ ""
+ "\\0") t t)))
(libxml-parse-html-region (point) (point-max))))))
(source (and (null document)
(buffer-substring (point) (point-max)))))
- bug#34469: 26.1; EWW stops renderring web page on null byte, Lukasz Pawelczyk, 2019/02/13
- bug#34469: 26.1; EWW stops renderring web page on null byte, Nicholas Drozd, 2019/02/13
- bug#34469: 26.1; EWW stops renderring web page on null byte, Nicholas Drozd, 2019/02/16
- bug#34469: 26.1; EWW stops renderring web page on null byte, Glenn Morris, 2019/02/18
- bug#34469: 26.1; EWW stops renderring web page on null byte, Robert Pluim, 2019/02/19
- bug#34469: 26.1; EWW stops renderring web page on null byte, Eli Zaretskii, 2019/02/19
- bug#34469: 26.1; EWW stops renderring web page on null byte, Robert Pluim, 2019/02/19
- bug#34469: 26.1; EWW stops renderring web page on null byte, Eli Zaretskii, 2019/02/19
- bug#34469: 26.1; EWW stops renderring web page on null byte,
Robert Pluim <=
- bug#34469: 26.1; EWW stops renderring web page on null byte, Robert Pluim, 2019/02/27
- bug#34469: 26.1; EWW stops renderring web page on null byte, Eli Zaretskii, 2019/02/27
- bug#34469: 26.1; EWW stops renderring web page on null byte, Robert Pluim, 2019/02/27
bug#34469: 26.1; EWW stops renderring web page on null byte, Paul Eggert, 2019/02/27