[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#34065: 26.1; Make edebug-eval-expression support code completion
From: |
mail |
Subject: |
bug#34065: 26.1; Make edebug-eval-expression support code completion |
Date: |
Wed, 20 Feb 2019 12:37:53 +0800 |
20.01.2019, 10:15, "Federico Tedin" <federicotedin@gmail.com>:
> Xu Chunyang <mail@xuchunyang.me> writes:
>
>> When type e (edebug-eval-expression) within Edebug, I notice there is no
>> code completion, unlike
>> M-: (eval-expression). So I wonder if edebug-eval-expression can behave
>> like eval-expression, I guess simply replacing read-from-minibuffer with
>> read--expression should work, though I've not tried.
>
> I've created a small patch which replaces `read-from-minibuffer' for
> `read--expression' in `edebug-eval-expression'. I would appreciate it if
> a maintainer could take a quick look.
I'm not a maintainer. Your patch looks good to me. Today I notice it's possible
to change the interactive form via Advising Functions, so I plan to put the
following to my init file until the patch is applied.
(define-advice edebug-eval-expression (:before (_expr) better-interactive-form)
"Fix the original interactive form."
(interactive (list (read--expression "Edebug Eval: "))))
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- bug#34065: 26.1; Make edebug-eval-expression support code completion,
mail <=