[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#32189: 27.0.50; GCC 7 warning due to -Wformat-truncation=2
From: |
Paul Eggert |
Subject: |
bug#32189: 27.0.50; GCC 7 warning due to -Wformat-truncation=2 |
Date: |
Fri, 20 Jul 2018 07:37:18 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
Ken Brown wrote:
Amended patch attached.
Thanks for checking it. I installed it in master.
Eli Zaretskii wrote:
> GCC 7 is not exactly "old".
True.
> If you are saying
> that this switch does a better job in later versions of GCC,
Yes, it does in some cases. I don't know whether it does in this particular
case. Someone would have to check. But I wouldn't bother checking since we have
a better fix now anyway (which is often the case for this particular warning).
> maybe we should disable it for GCC 7 alone?
I'd rather not bother. Better to move on. The general rule for warnings should
be to cater to the latest GCC, and not worry much about older ones. (I used to
try doing things the other way and it was way more trouble than it was worth.)
We need to cater to old compilers for correctness, but we don't need to do it
for warnings.
- bug#32189: 27.0.50; GCC 7 warning due to -Wformat-truncation=2, (continued)
- bug#32189: 27.0.50; GCC 7 warning due to -Wformat-truncation=2, Philipp Stephani, 2018/07/19
- bug#32189: 27.0.50; GCC 7 warning due to -Wformat-truncation=2, Eli Zaretskii, 2018/07/19
- bug#32189: 27.0.50; GCC 7 warning due to -Wformat-truncation=2, Ken Brown, 2018/07/19
- bug#32189: 27.0.50; GCC 7 warning due to -Wformat-truncation=2, Eli Zaretskii, 2018/07/19
- bug#32189: 27.0.50; GCC 7 warning due to -Wformat-truncation=2, Paul Eggert, 2018/07/19
- bug#32189: 27.0.50; GCC 7 warning due to -Wformat-truncation=2, Eli Zaretskii, 2018/07/20
- bug#32189: 27.0.50; GCC 7 warning due to -Wformat-truncation=2, Ken Brown, 2018/07/20
- bug#32189: 27.0.50; GCC 7 warning due to -Wformat-truncation=2, Eli Zaretskii, 2018/07/20
- bug#32189: 27.0.50; GCC 7 warning due to -Wformat-truncation=2, Ken Brown, 2018/07/20
- bug#32189: 27.0.50; GCC 7 warning due to -Wformat-truncation=2,
Paul Eggert <=
- bug#32189: 27.0.50; GCC 7 warning due to -Wformat-truncation=2, Eli Zaretskii, 2018/07/20
- bug#32189: 27.0.50; GCC 7 warning due to -Wformat-truncation=2, Ken Brown, 2018/07/20
- bug#32189: 27.0.50; GCC 7 warning due to -Wformat-truncation=2, Paul Eggert, 2018/07/20