[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#29478: [Patch] bug#29478: 26.0.90; `C-h k' followed by mouse clicks
From: |
Eli Zaretskii |
Subject: |
bug#29478: [Patch] bug#29478: 26.0.90; `C-h k' followed by mouse clicks no longer shows down event |
Date: |
Sat, 23 Dec 2017 14:41:42 +0200 |
> Date: Sat, 23 Dec 2017 11:17:26 +0000
> Cc: Stefan Monnier <monnier@iro.umontreal.ca>, 29478@debbugs.gnu.org,
> npostavs@users.sourceforge.net
> From: Alan Mackenzie <acm@muc.de>
>
> Of course! read-key-sequence consumes all the events up to the
> S-down-mouse-1, leaving the following S-mouse-1 in the event buffer.
> This is read at the next iteration of the command loop.
>
> > CC'ing Stefan in the hope that he could have some insights.
>
> OK, I have a provisional fix. The problem was that the double-click-time
> loop in help-read-key-sequence was discarding all events but the last
> one. I have amended the loop so that _all_ these events are stored in a
> list, and we then discard the most recent events till we find one with a
> binding.
>
> This patch seems to work with GPM in a Linux tty, and also in X-Windows
> (I think). (It is based on the emacs-26 branch, of course.)
LGTM, thanks. The problem I reported is gone with this patch.
- bug#29478: 26.0.90; `C-h k' followed by mouse clicks no longer shows down event, Eli Zaretskii, 2017/12/01
- bug#29478: 26.0.90; `C-h k' followed by mouse clicks no longer shows down event, Drew Adams, 2017/12/01
- bug#29478: 26.0.90; `C-h k' followed by mouse clicks no longer shows down event, Eli Zaretskii, 2017/12/01
- bug#29478: 26.0.90; `C-h k' followed by mouse clicks no longer shows down event, Eli Zaretskii, 2017/12/09
- bug#29478: 26.0.90; `C-h k' followed by mouse clicks no longer shows down event, Alan Mackenzie, 2017/12/09
- bug#29478: 26.0.90; `C-h k' followed by mouse clicks no longer shows down event, Alan Mackenzie, 2017/12/22
- bug#29478: 26.0.90; `C-h k' followed by mouse clicks no longer shows down event, Eli Zaretskii, 2017/12/23
- bug#29478: [Patch] bug#29478: 26.0.90; `C-h k' followed by mouse clicks no longer shows down event, Alan Mackenzie, 2017/12/23
- bug#29478: [Patch] bug#29478: 26.0.90; `C-h k' followed by mouse clicks no longer shows down event,
Eli Zaretskii <=
- bug#29478: [Patch] bug#29478: 26.0.90; `C-h k' followed by mouse clicks no longer shows down event, Stefan Monnier, 2017/12/23
- bug#29478: [Patch] bug#29478: 26.0.90; `C-h k' followed by mouse clicks no longer shows down event, Alan Mackenzie, 2017/12/23
- bug#29478: [Patch] bug#29478: 26.0.90; `C-h k' followed by mouse clicks no longer shows down event, Stefan Monnier, 2017/12/23
- bug#29478: [Patch] bug#29478: 26.0.90; `C-h k' followed by mouse clicks no longer shows down event, Eli Zaretskii, 2017/12/24
- bug#29478: [Patch] bug#29478: 26.0.90; `C-h k' followed by mouse clicks no longer shows down event, Stefan Monnier, 2017/12/24
- bug#29478: [Patch] bug#29478: 26.0.90; `C-h k' followed by mouse clicks no longer shows down event, Alan Mackenzie, 2017/12/24
- bug#29478: [Patch] bug#29478: 26.0.90; `C-h k' followed by mouse clicks no longer shows down event, Stefan Monnier, 2017/12/24
- bug#29478: [Patch] bug#29478: 26.0.90; `C-h k' followed by mouse clicks no longer shows down event, Eli Zaretskii, 2017/12/30
- bug#29478: [Patch] bug#29478: 26.0.90; `C-h k' followed by mouse clicks no longer shows down event, Eli Zaretskii, 2017/12/30
- bug#29478: [Patch] bug#29478: 26.0.90; `C-h k' followed by mouse clicks no longer shows down event, Alan Mackenzie, 2017/12/30