[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#29456: [PATCH] Add command for cycling between CSS color formats
From: |
Eli Zaretskii |
Subject: |
bug#29456: [PATCH] Add command for cycling between CSS color formats |
Date: |
Mon, 27 Nov 2017 20:11:21 +0200 |
> From: Tom Tromey <tom@tromey.com>
> Cc: Simen Heggestøyl <simenheg@gmail.com>,
> 29456@debbugs.gnu.org, tom@tromey.com, monnier@iro.umontreal.ca
> Date: Mon, 27 Nov 2017 10:41:29 -0700
>
> >>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
>
> Eli> The latter follows the X color definitions, so why does css-mode.el
> Eli> need a different interpretation of the hex-RGB notation?
>
> CSS color names came from X a long time ago, but their mapping to rgb is
> now part of the CSS specification. And, apparently there were multiple
> versions of this file coming from X. The Emacs one would be ok provided
> the lists are identical and will always remain so. Otherwise, css-mode
> needs its own list.
Sorry, I don't understand: what list are you talking about?
> Eli> My fear is that someone will mix css-mode functions with those from
> Eli> elsewhere in Emacs, and will bump into confusing and contradicting
> Eli> results. Is it possible to avoid that?
>
> Using "css-" in the name seems sufficient to me. Maybe a comment
> explaining this would help as well.
A comment will help, but I'm actually wondering why does css-mode need
to use 12-bit or 16-bit per component RGB notation? Why not use only
8-bit, as in #RRGGBB? The problems only happen in converting 8-bit
RGB notations to higher number of bits.