bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#28227: 26.0.50; Tramp tests are slow


From: Gemini Lasswell
Subject: bug#28227: 26.0.50; Tramp tests are slow
Date: Thu, 31 Aug 2017 07:46:33 -0700
User-agent: mu4e 0.9.18; emacs 25.1.1

Here's a new patch which uses defun and doesn't have the let binding.
Performance is not noticably different.

Attachment: 0001-Reduce-Tramp-s-memory-usage.patch
Description: Text document


npostavs@users.sourceforge.net writes:

> Gemini Lasswell <gazally@runbox.com> writes:
>
>> +(defmacro tramp-lookup-syntax (alist)
>> +  "Look up a syntax string in ALIST according to 
>> `tramp-compat-tramp-syntax.'
>> +Raise an error if `tramp-syntax' is invalid."
>> +  `(let ((result (cdr (assq (tramp-compat-tramp-syntax) ,alist))))
>> +     (or result
>> +         (error "Wrong `tramp-syntax' %s" tramp-syntax))))
>
> Was there a reason to defmacro instead of defun here?  If it's
> performance, perhaps defsubst could work instead?
>
> (also, the let-binding seems redundant)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]