bug#24901: Caught mistake in elec-pair.el patch

[João Távora]

Turns out it's not so simple, because electric-pair-text-pairs is autoloaded

and thus relying on electric-quote-chars is a problem.

Loading loaddefs.el (source)...

Symbol's value as variable is void: electric-quote-chars

Makefile:535: recipe for target 'emacs' failed

I could:

1. Add an autoload to electric-quote-chars. (Unfortunately I seem to fail at that,

just adding the cookie isn't enough, it has to go into ldefs-boot.el somehow).

2. Replace those (nth...) expressions with the actual quote characters. It's no 

more disconnected from a possible customized value in electric-quote-chars 

than it is now.

3. Rework elec-pair.el so that lisp expressions are accepted in electric-pair-text-pairs

and evaluated just-in-time.

Anyway, It's been more than 1 year since my last contribution to Emacs, and

I shouldn't make this decision alone. Eli, could you please weigh in or point me

to someone who can? Emacs-devel?

Thanks,

João 

 

On Sun, Aug 13, 2017 at 11:59 AM, Reuben Thomas <rrt@sc3d.org> wrote:

Thanks very much, I fear that was just ineptitude on my part.

--
https://rrt.sc3d.org

On 13 Aug 2017 11:57 am, "João Távora" <joaotavora@gmail.com> wrote:

Hi Reuben,

Casually glancing at the source for lisp/elec-pair.el I have found an error. 

You cannot use lists like (nth 0 electric-quote-chars) inside a quoted list as 

you did in your patch of Nov. 8 2016. The list will not be evaluated. Perhaps 

you were distracted by the grim events taking place that day :-) 

Anyway, I think you meant backquote-and-comma so I'll install this fix soon,

unless anyone objects.

João

diff --git a/lisp/elec-pair.el b/lisp/elec-pair.el

index 87e82e2..4ede4f1 100644

--- a/lisp/elec-pair.el

+++ b/lisp/elec-pair.el

@@ -28,9 +28,9 @@

 ;;; Electric pairing.

 

 (defcustom electric-pair-pairs

-  '((?\" . ?\")

-    ((nth 0 electric-quote-chars) . (nth 1 electric-quote-chars))

-    ((nth 2 electric-quote-chars) . (nth 3 electric-quote-chars)))

+  `((?\" . ?\")

+    (,(nth 0 electric-quote-chars) . ,(nth 1 electric-quote-chars))

+    (,(nth 2 electric-quote-chars) . ,(nth 3 electric-quote-chars)))

   "Alist of pairs that should be used regardless of major mode.

 

 Pairs of delimiters in this list are a fallback in case they have

@@ -44,9 +44,9 @@ electric-pair-pairs

 

 ;;;###autoload

 (defcustom electric-pair-text-pairs

-  '((?\" . ?\" )

-    ((nth 0 electric-quote-chars) . (nth 1 electric-quote-chars))

-    ((nth 2 electric-quote-chars) . (nth 3 electric-quote-chars)))

+  `((?\" . ?\" )

+    (,(nth 0 electric-quote-chars) . ,(nth 1 electric-quote-chars))

+    (,(nth 2 electric-quote-chars) . ,(nth 3 electric-quote-chars)))

   "Alist of pairs that should always be used in comments and strings.

 

 Pairs of delimiters in this list are a fallback in case they have