[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#27762: 26.0.50; ls-lisp: misalignment when dired-directory is a cons
From: |
Tino Calancha |
Subject: |
bug#27762: 26.0.50; ls-lisp: misalignment when dired-directory is a cons |
Date: |
Wed, 02 Aug 2017 00:08:02 +0900 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) |
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Tino Calancha <tino.calancha@gmail.com>
>> Cc: 27762@debbugs.gnu.org
>> Date: Tue, 01 Aug 2017 16:01:17 +0900
>>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>> > Looks OK, but why this complicated code:
>> >
>> >> + (when-let* ((col-diff (- (point) (point-at-bol)))
>> >> + (higher (> col-diff target)))
>> >> + (setq target col-diff)))
>> >> + (and (/= first target) target))))
>> >
>> > Doesn't current-column do its job in this case?
>> That is to work regardless on the `dired-hide-details-mode' value.
>> If we use `current-column' we are in trouble.
>
> Then (a) please mention this issue in a comment before this fragment,
> and (b) please don't call the variable "column", because it's
> confusing.
a) The comment is right before the while loop.
b) Done.
Pushed into master as commit f74164a845eff579635da0a1267514ef9d040ad2