[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#25618: 25.1.91; More precise limit for tagging expensive tests
From: |
Noam Postavsky |
Subject: |
bug#25618: 25.1.91; More precise limit for tagging expensive tests |
Date: |
Sat, 4 Feb 2017 09:01:49 -0500 |
On Sat, Feb 4, 2017 at 8:42 AM, Tino Calancha <tino.calancha@gmail.com> wrote:
>
> Prefer set a numeric limit of seconds than using the word 'few'.
>
> For instance, in my box the test `cl-seq-test-bug24264' in
> test/lisp/emacs-lisp/cl-seq-tests.el
> takes 7 s.
> With an explicit numeric threshold is easier to decide whether this test
> must be tagged as expensive or not.
>
> In following patch i define a few as 2-3 seconds. Other people might
> prefer 4-5 or even higher.
> Please, suggest a proper value to consider a test as expensive.
Is it worth specifying this so precisely? The time elapsed depends on
the speed of the computer you run it on (also, whether Emacs is
compiled with optimization or not). A test that takes 2 seconds on
your computer might easily take 5 seconds on mine.