bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#24389: [PATCH] Support completion of classes and IDs in CSS mode


From: Stefan Monnier
Subject: bug#24389: [PATCH] Support completion of classes and IDs in CSS mode
Date: Sat, 17 Sep 2016 08:35:12 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux)

> OK, I changed it to use the buffer's tick counter instead. I also
> changed `seq-uniq' to `delete-dups', which resulted in a massive
> speedup. Some benchmarks using the same test files as before follow.
[...]
> As a side note, maybe a hashing strategy like the one `delete-dups'
> uses would be good for `seq-uniq' too?

I suggest you file a separate bug report for that issue.  Maybe using
a hash table like in delete-dups will do the trick, but I suspect that
the difference between using `delete` (coded in C) vs `seq-contains`
(which additionally performs an Elisp-funcall for each element) is also
a significant factor.

The patch looks good now, thanks,


        Stefan





reply via email to

[Prev in Thread] Current Thread [Next in Thread]