[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#24240: 25.1.50; window-state-put, image-mode and window scrolling
From: |
Andreas Politz |
Subject: |
bug#24240: 25.1.50; window-state-put, image-mode and window scrolling |
Date: |
Wed, 17 Aug 2016 12:33:19 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) |
martin rudalics <rudalics@gmx.at> writes:
> We can abuse ‘frame-after-make-frame’. Try the attached, completely
> untested patch.
>
> BTW I just noticed that we still run ‘window-configuration-change-hook’
> in far too many cases.
(defmacro with-inhibit-window-configuration-change-hook (frame &rest body)
"Inhibit `window-configuration-change-hook' on FRAME in BODY."
(declare (indent 1) (debug t))
(let ((frame-var (make-symbol "frame")))
`(let ((,frame-var (window-normalize-frame ,frame)))
(unwind-protect
(progn
(frame-after-make-frame ,frame-var nil)
,@body)
(frame-after-make-frame ,frame-var t)))))
> Would my patch work around that?
It seems to inhibit running the hook, but there is still the case of
set-window-start in window--state-put-2. Using the NOFORCE works, but I
don't know the implications of this in other cases.
diff --git a/lisp/window.el b/lisp/window.el
index 11d7a4e..d30819d 100644
--- a/lisp/window.el
+++ b/lisp/window.el
@@ -5497,7 +5497,7 @@ window--state-put-2
;; Install positions (maybe we should do this after all
;; windows have been created and sized).
(ignore-errors
- (set-window-start window (cdr (assq 'start state)))
+ (set-window-start window (cdr (assq 'start state)) 'noforce)
(set-window-point window (cdr (assq 'point state))))
;; Select window if it's the selected one.
(when (cdr (assq 'selected state))
-ap
- bug#24240: 25.1.50; window-state-put, image-mode and window scrolling, Andreas Politz, 2016/08/15
- bug#24240: 25.1.50; window-state-put, image-mode and window scrolling, martin rudalics, 2016/08/16
- bug#24240: 25.1.50; window-state-put, image-mode and window scrolling, Andreas Politz, 2016/08/16
- bug#24240: 25.1.50; window-state-put, image-mode and window scrolling, martin rudalics, 2016/08/17
- bug#24240: 25.1.50; window-state-put, image-mode and window scrolling,
Andreas Politz <=
- bug#24240: 25.1.50; window-state-put, image-mode and window scrolling, martin rudalics, 2016/08/17
- bug#24240: 25.1.50; window-state-put, image-mode and window scrolling, Andreas Politz, 2016/08/17
- bug#24240: 25.1.50; window-state-put, image-mode and window scrolling, martin rudalics, 2016/08/18