[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#24213: 25.1.50; Fishy use of delete-window in register.el
|
From: |
Leo Liu |
|
Subject: |
bug#24213: 25.1.50; Fishy use of delete-window in register.el |
|
Date: |
Sat, 13 Aug 2016 10:39:49 +0800 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (OS X 10.11.6) |
On 2016-08-12 22:22 +0200, Andreas Politz wrote:
> The register.el commands display a preview of register contents, using
> display-buffer in register-preview. Later, when some register was
> chosen by the user, the window showing this preview is closed via
> delete-window.
The window is created by `display-buffer-below-selected' so we know its
ours and thus delete-window is technically safe here. Use
quit-window/quit-windows-on is ok as well for being defensive.
Martin,
it seems the documentation of display-buffer-below-selected isn't clear
that it only reuses a window if it displays BUFFER already.
Leo
bug#24213: 25.1.50; Fishy use of delete-window in register.el, martin rudalics, 2016/08/13