bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#23964: 25.1.50; `+' no longer works on images in Gnus article buffer


From: Katsumi Yamaoka
Subject: bug#23964: 25.1.50; `+' no longer works on images in Gnus article buffers
Date: Mon, 25 Jul 2016 07:53:13 +0900
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (i686-pc-cygwin)

On Sun, 24 Jul 2016 10:27:51 +0200, Lars Ingebrigtsen wrote:
> It works for `+', but commands like `a' and `RET' no still doesn't work
> on <a><img></a> links.  :-)

I was confused about what key bindings should be there. :-)  But
this would probably be the right way:

--8<---------------cut here---------------start------------->8---
--- mm-decode.el~       2016-07-14 02:18:17.358607500 +0000
+++ mm-decode.el        2016-07-24 22:48:23.134292500 +0000
@@ -1853,8 +1853,6 @@
         :help-echo (get-text-property start 'help-echo)
         :keymap (setq keymap (copy-keymap shr-image-map))
         (get-text-property start 'shr-url))
-       ;; Remove keymap that `shr-urlify' adds.
-       (put-text-property start end 'keymap nil)
        ;; Mask keys that launch `widget-button-click'.
        ;; Those bindings are provided by `widget-keymap'
        ;; that is a parent of `gnus-article-mode-map'.
--8<---------------cut here---------------end--------------->8---

(Don't apply my last patch to shr.el.)

How about it?

This used to be making `local-map', not `keymap', void:
<http://article.gmane.org/gmane.emacs.diffs/136052>
The reason I did it was there's no code using `local-map', and
so it was never effective.  So, the patch above only restores
the old behavior. :-)





reply via email to

[Prev in Thread] Current Thread [Next in Thread]