bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#24030: 25.0.95; mouse-drag-region regression


From: Stefan Monnier
Subject: bug#24030: 25.0.95; mouse-drag-region regression
Date: Sun, 24 Jul 2016 11:02:38 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux)

> --- lisp/mouse.el~    2016-07-20 09:52:16.559875700 +0300
> +++ lisp/mouse.el     2016-07-24 17:14:34.469052800 +0300
> @@ -815,14 +815,16 @@ The region will be defined with mark and
>    (setq mouse-selection-click-count-buffer (current-buffer))
>    (deactivate-mark)
>    (let* ((scroll-margin 0) ; Avoid margin scrolling (Bug#9541).
> +      (start-posn (event-start start-event))
> +      (start-point (posn-point start-posn))
> +      (start-window (posn-window start-posn))
> +      (_ (with-selected-window start-window
> +           (setq deactivate-mark nil)))
>           ;; We've recorded what we needed from the current buffer and
>           ;; window, now let's jump to the place of the event, where things
>           ;; are happening.
>           (_ (mouse-set-point start-event))
>           (echo-keystrokes 0)
> -      (start-posn (event-start start-event))
> -      (start-point (posn-point start-posn))
> -      (start-window (posn-window start-posn))
>        (bounds (window-edges start-window))
>        (make-cursor-line-fully-visible nil)
>        (top (nth 1 bounds))

Looks fine to me, tho I don't think we should use with-selected-window
here, but only with-current-buffer.


        Stefan





reply via email to

[Prev in Thread] Current Thread [Next in Thread]