[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#24035: 25.1.50; Eww breaks on images?
From: |
Clément Pit--Claudel |
Subject: |
bug#24035: 25.1.50; Eww breaks on images? |
Date: |
Wed, 20 Jul 2016 16:13:57 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
On 2016-07-20 11:35, Kaushal Modi wrote:
> OK, cool!
>
> How did you figure that out? Also how did shr get incorrectly compiled?
shr calls setf on (image-property). That will only work if there's a setter
defined for image-property; otherwise, the setf macro will be expanded
incorrectly at compile time. That setter is only available if image has been
loaded.
> So then, this commit (
> http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=90fb0b2d13d0f44ecb9606587681cb4d8a6f0225
> ) should not be needed.
I think this is the right fix. shr does require image to be loaded for the setf
to compile properly. Thus the dependency explicit is the right thing to do (I
think).
Cheers,
Clément.
signature.asc
Description: OpenPGP digital signature
- bug#24035: 25.1.50; Eww breaks on images?, (continued)
- bug#24035: 25.1.50; Eww breaks on images?, Clément Pit--Claudel, 2016/07/20
- bug#24035: 25.1.50; Eww breaks on images?, Lars Ingebrigtsen, 2016/07/20
- bug#24035: 25.1.50; Eww breaks on images?, Clément Pit--Claudel, 2016/07/20
- bug#24035: 25.1.50; Eww breaks on images?, Lars Ingebrigtsen, 2016/07/20
- bug#24035: 25.1.50; Eww breaks on images?, Clément Pit--Claudel, 2016/07/20
- bug#24035: 25.1.50; Eww breaks on images?, Lars Ingebrigtsen, 2016/07/20
bug#24035: 25.1.50; Eww breaks on images?, Kaushal Modi, 2016/07/20
bug#24035: 25.1.50; Eww breaks on images?, Lars Ingebrigtsen, 2016/07/20
bug#24035: 25.1.50; Eww breaks on images?, Kaushal Modi, 2016/07/20