bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#23648: [PATCH] `defun-declarations-alist' can be unintentionally mod


From: Dmitry Gutov
Subject: bug#23648: [PATCH] `defun-declarations-alist' can be unintentionally modified
Date: Mon, 18 Jul 2016 22:17:56 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:47.0) Gecko/20100101 Thunderbird/47.0

On 07/18/2016 06:00 AM, npostavs@users.sourceforge.net wrote:

Here `delete-dups' destructively modifies a list that includes
`defun-declarations-alist' as its tail verbatim, not as a copy.
Attached patch should fix that.

I agree with analysis and patch here.

I like the patch as well. Maybe it would be better to use cl-remove-duplicates with nconc instead (the use of nil is a little non-obvious), but that would require having cl-lib loaded at runtime, and elisp-mode depending on it.

In any case, the proposed patch looks safe.






reply via email to

[Prev in Thread] Current Thread [Next in Thread]