[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#16856: [PATCH] Prevent bar cursor overwriting next glyph (bug#16856)
From: |
David Reitter |
Subject: |
bug#16856: [PATCH] Prevent bar cursor overwriting next glyph (bug#16856) |
Date: |
Mon, 18 Jul 2016 07:54:03 +0900 |
No ill effects with that. What is the glyph at the end of the line?
Also, about your patch, it seems like w->phys_cursor_width will then just be
whatever it was before.
> On Jul 17, 2016, at 10:51 PM, Alan Third <alan@idiocy.org> wrote:
>
> * src/nsterm.m (ns_draw_window_cursor): Test glyph width vs cursor width
> before setting final size.
> ---
> src/nsterm.m | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/src/nsterm.m b/src/nsterm.m
> index a6160ed..8da2ffe 100644
> --- a/src/nsterm.m
> +++ b/src/nsterm.m
> @@ -2861,7 +2861,10 @@ Note that CURSOR_WIDTH is meaningful only for (h)bar
> cursors.
> {
> if (cursor_width < 1)
> cursor_width = max (FRAME_CURSOR_WIDTH (f), 1);
> - w->phys_cursor_width = cursor_width;
> +
> + /* The bar cursor should never be wider than the glyph. */
> + if (cursor_width < w->phys_cursor_width)
> + w->phys_cursor_width = cursor_width;
> }
> /* If we have an HBAR, "cursor_width" MAY specify height. */
> else if (cursor_type == HBAR_CURSOR)
> --
>
> And here's a patch to prevent the bar cursor straying into the next glyph.
> --
> Alan Third