[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#22814: 25.0.91; Emacs runs out of file descriptors on OS X
From: |
Eli Zaretskii |
Subject: |
bug#22814: 25.0.91; Emacs runs out of file descriptors on OS X |
Date: |
Fri, 04 Mar 2016 10:29:40 +0200 |
> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: andlind@gmail.com, 22814@debbugs.gnu.org
> Date: Fri, 04 Mar 2016 08:53:24 +0100
>
> > The only part that might be worth improving is the error message: it's
> > a far cry from what really went wrong. If you can find a way of
> > making it say something about "too many open files", that'd be all the
> > improvement we can hope for.
>
> I would apply the following patch:
>
> --8<---------------cut here---------------start------------->8---
> ***
> /home/albinus/src/emacs-25/src/doc.c.~2e78353fabe11c768627c50e48375de5693ce7ee~
> --- /home/albinus/src/emacs-25/src/doc.c
> ***************
> *** 126,131 ****
> --- 126,134 ----
> fd = emacs_open (name, O_RDONLY, 0);
> if (fd < 0)
> {
> + if ((errno == EMFILE) || (errno == ENFILE))
> + report_file_error ("Read error on documentation file", file);
> +
> #ifndef CANNOT_DUMP
> if (!NILP (Vpurify_flag))
> {
> --8<---------------cut here---------------end--------------->8---
>
> This ends up in the following error message:
>
> Read error on documentation file: Too many open files,
> /home/albinus/src/emacs-25/lisp/emacs-lisp/cl-seq.elc
LGTM.
> Is it OK to apply it to the emacs-25 branch, or shall it go to master?
Please commit to emacs-25, and thanks.