[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#12413: 24.2.50; M-j should be bound to default-indent-new-line
From: |
Lars Ingebrigtsen |
Subject: |
bug#12413: 24.2.50; M-j should be bound to default-indent-new-line |
Date: |
Wed, 24 Feb 2016 17:11:35 +1100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) |
Dmitry Gutov <dgutov@yandex.ru> writes:
> A major mode can change the value of comment-line-break-function, but
> currently it's only used from `do-auto-fill'. I think that doesn't make
> sense, the value should affect the M-j command, too.
>
> default-indent-new-line does pretty much that. The function could use a
> better name, though - it isn't used in any variables as default value.
[...]
I think this makes sense, but it wasn't applied at the time (three years
ago). Is this still an issue?
> (define-key esc-map ";" 'comment-dwim)
> -(define-key esc-map "j" 'indent-new-comment-line)
> -(define-key esc-map "\C-j" 'indent-new-comment-line)
> +(define-key esc-map "j" 'default-indent-new-line)
> +(define-key esc-map "\C-j" 'default-indent-new-line)
> (define-key ctl-x-map ";" 'comment-set-column)
> (define-key ctl-x-map "f" 'set-fill-column)
> (define-key ctl-x-map "$" 'set-selective-display)
>
> === modified file 'lisp/simple.el'
> --- lisp/simple.el 2012-09-07 08:58:31 +0000
> +++ lisp/simple.el 2012-09-11 06:34:40 +0000
> @@ -5501,7 +5501,7 @@
>
> (defun default-indent-new-line (&optional soft)
> "Break line at point and indent.
> -If a comment syntax is defined, call `comment-indent-new-line'.
> +If a comment syntax is defined, call `comment-line-break-function'.
>
> The inserted newline is marked hard if variable `use-hard-newlines' is true,
> unless optional argument SOFT is non-nil."
>
> === modified file 'lisp/textmodes/refill.el'
> --- lisp/textmodes/refill.el 2012-07-11 23:13:41 +0000
> +++ lisp/textmodes/refill.el 2012-09-11 06:50:28 +0000
> @@ -179,7 +179,7 @@
> (refill-fill-paragraph-at refill-doit)
> (setq refill-doit nil)))
> ((or `quoted-insert `fill-paragraph `fill-region) nil)
> - ((or `newline `newline-and-indent `open-line `indent-new-comment-line
> + ((or `newline `newline-and-indent `open-line `default-indent-new-line
> `reindent-then-newline-and-indent)
> ;; Don't zap what was just inserted.
> (save-excursion
>
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- bug#12413: 24.2.50; M-j should be bound to default-indent-new-line,
Lars Ingebrigtsen <=