[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#22479: 25.0.50; isearch and query-replace histories do not remember
From: |
Dima Kogan |
Subject: |
bug#22479: 25.0.50; isearch and query-replace histories do not remember if we were looking for symbols |
Date: |
Mon, 01 Feb 2016 21:32:08 -0800 |
User-agent: |
mu4e 0.9.11; emacs 25.0.50.1 |
Juri Linkov <juri@linkov.net> writes:
>>> 5. More ideas? ;)
>>
>> - We can retain the two histories: regex, non-regex
>>
>> - Any fancy (word, symbol, etc) searches can be stored into the regex
>> history, bookmarked with the appropriate regexen ("\_<", "\_>" for
>> instance)
>>
>> - When reading the history to present to the user, these can be parsed
>> out. So for instance when the user looks through the symbol-search
>> history by hitting
>>
>> M-s _
>> C-s
>>
>> emacs can look through the regex history, only selecting entries in
>> \_<...\_>. The C-M-s history can either include all of these, or show
>> only unbookmarked entries; both would be ok, I think.
>
> This approach is compromising but unreliable
Indeed it is a compromise. It feels to me to be much better than what we
have now, and the issues aren't too significant... I think...
> (doesn't distinguish between the case when the user uses the symbol
> search M-s _ or types \_<...\_> directly in the regexp search)
True, but I think this is OK. The symbol-search history would include
M-s _ searches AND those C-M-s searches where the intent was to look for
symbols; I think this is fine. The regex-search history would include
all symbol searches also; maybe that is less fine, but it isn't crazy.
The text search history would include none of these; this is GOOD, and
is not what we do now.
> (need to remember other search parameters like case-fold and
> lax-whitespace).
Hmmm. This clearly requires metadata so some of your other, more
intrusive proposals would be required to handle this. The above proposal
would work for word and symbol searches. I think fixing that would be
worth it. Do yall just want to leave it alone?
- bug#22479: 25.0.50; isearch and query-replace histories do not remember if we were looking for symbols,
Dima Kogan <=