bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#21707: include-file cleanup for src directory


From: Paul Eggert
Subject: bug#21707: include-file cleanup for src directory
Date: Mon, 19 Oct 2015 22:54:39 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

Eli Zaretskii wrote:
I had compilation warnings and errors due to redisplaying_p and
cancel_hourglass not being declared in eval.c and lread.c.  These two
files need to include dispextern.h to avoid that problem.  (This isn't
Windows specific, so I wonder how it compiled for you.)

It's a problem with platform-specific inclusions: xterm.h includes dispextern.h, but eval.c and lread.c don't include xterm.h on MS-Windows. I attempted to detect this sort of thing by hand without actually building on MS-Windows, but it's an easy thing to get wrong. Revised patch attached. Quite possibly there will be similar issues on other platforms, but they should be easy to fix once encountered.

Attachment: 0001-Include-file-cleanup-for-src-directory.txt
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]