|
From: | Dmitry Gutov |
Subject: | bug#21383: Static revisions in vc-working-revision |
Date: | Tue, 1 Sep 2015 15:05:27 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:40.0) Gecko/20100101 Thunderbird/40.0 |
On 09/01/2015 06:55 AM, Stefan Monnier wrote:
VC was originally designed so as to separate the VC data from the buffers, so the `file' argument was absolutely indispensable (you can't/shouldn't rely on things like the current-buffer's default-directory). I think nowadays the design has been changed enough that indeed the `file' arg can be dispensed with.
I think just the current usage, everywhere, makes it okay. But if I were to inquire of the status of a file in a different repository, that would still fail. We don't don't seem to do that anywhere, though, and supporting that usage would require fixes in multiple places.
This patch doesn't change much in this regard: FILE wasn't used for its default-directory even before it.
The rest looks OK to me,
Thanks, installed.
[Prev in Thread] | Current Thread | [Next in Thread] |