[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#16204: eww does not respect shr-width customization
From: |
Kenjiro NAKAYAMA |
Subject: |
bug#16204: eww does not respect shr-width customization |
Date: |
Sat, 21 Dec 2013 23:49:40 +0900 |
User-agent: |
mu4e 0.9.9.6pre2; emacs 24.3.50.1 |
Thank you for your review. But I have some comments. I'm sorry if I
misunderstood.
> I’d also ask for a separate “do not override” value. That is:
>
> (shr-width (if (DO-NOT-SET-P eww-rendering-width)
> shr-width
> eww-rendering-width))
I'm not sure how to work well with this logic.
I think shr-width should be overridden by nil or new rendering-width
every time, since previous windows-width will be set to shr-width next
rendering.
When users change their window-width, the shr-width should be current
window-width, not previous width.
> > +(defvar eww-rendering-width nil)
>
> Shouldn’t it rather be defcustom?
For the above reason, I think defvar is ok.
> Shouldn’t this rather be ‘error’?
Yes, it is my mistake. Sorry.
Kenjiro Nakayama
ivan@siamics.net writes:
>>>>>> Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com> writes:
>>>>>> ivan@siamics.net writes:
>
> >> Package: emacs Severity: wishlist
>
> >> As currently implemented, eww-display-html simply resets shr-width
> >> to nil, disrespecting any user’s customization thereof, and
> >> providing no easy way to specify the HTML rendering width to use in
> >> EWW buffers.
>
> > Yes, I think so too. I wrote the patch to cusomize rendering-width
> > (shr-width) easily by users.
>
> ACK, thanks!
>
> […]
>
> > --- a/lisp/net/eww.el
> > +++ b/lisp/net/eww.el
> > @@ -129,6 +129,7 @@ See also `eww-form-checkbox-selected-symbol'."
> > (defvar eww-home-url nil)
> > (defvar eww-start-url nil)
> > (defvar eww-contents-url nil)
> > +(defvar eww-rendering-width nil)
>
> Shouldn’t it rather be defcustom?
>
> > (defvar eww-local-regex "localhost"
> > "When this regex is found in the URL, it's not a keyword but an
> address.")
> > @@ -255,7 +256,7 @@ word(s) will be searched for via `eww-search-prefix'."
> > (setq eww-current-dom document)
> > (let ((inhibit-read-only t)
> > (after-change-functions nil)
> > - (shr-width nil)
> > + (shr-width eww-rendering-width)
>
> I’d also ask for a separate “do not override” value. That is:
>
> (shr-width (if (DO-NOT-SET-P eww-rendering-width)
> shr-width
> eww-rendering-width))
>
> (And, similarly, defcustom’s :type above being a ‘choice’.)
>
> > (shr-target-id (url-target (url-generic-parse-url url)))
> > (shr-external-rendering-functions
> > '((title . eww-tag-title)
>
> […]
>
> > @@ -543,6 +546,15 @@ appears in a <link> or <a> tag."
> > (url-retrieve eww-current-url 'eww-render
> > (list eww-current-url (point))))
>
> > +(defun eww-set-rendering-width (width)
> > + "Set the redering width."
> > + (interactive "nSet new redering width (0: window-width) :")
> > + (if (zerop width)
> > + (setq eww-rendering-width nil)
> > + (if (wholenump width)
> > + (setq eww-rendering-width width)
> > + (message "Set Number to rendering width"))))
>
> Shouldn’t this rather be ‘error’?
>
> > +
> > ;; Form support.
>
> > (defvar eww-form nil)