[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#9803: [PATCH] Add ERT option to skip test
From: |
Michael Albinus |
Subject: |
bug#9803: [PATCH] Add ERT option to skip test |
Date: |
Mon, 21 Oct 2013 17:08:31 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) |
Michael Albinus <michael.albinus@gmx.de> writes:
Hi Glenn,
>> I think `skip-if' should have an ert- prefix. (I know `should' doesn't,
>> but I think it, err, should as well. But too late for that one now.)
>
> I've tried to change it as proposed by Stefan, but I'm too stupid to
> manage all this sophisticated cl-* stuff :-(
Well, I've made a change to call (fset 'skip-if 'ert--skip-if) in
ert--run-test-internal. After running the test, it is reverted by
(unintern 'skip-if nil).
Therefore, `skip-if' is visible only inside tests defined with
`ert-deftest'. If this is acceptable, I could apply this change also for
`should', `should-not' and `should-error'.
Do you (and Stefan) agree?
Best regards, Michael.
123.patch
Description: Text Data
- bug#9803: [PATCH] Add ERT option to skip test, Michael Albinus, 2013/10/18
- bug#9803: [PATCH] Add ERT option to skip test, Glenn Morris, 2013/10/18
- bug#9803: [PATCH] Add ERT option to skip test, Stefan Monnier, 2013/10/18
- bug#9803: [PATCH] Add ERT option to skip test, Michael Albinus, 2013/10/19
- bug#9803: [PATCH] Add ERT option to skip test, Michael Albinus, 2013/10/20
- bug#9803: [PATCH] Add ERT option to skip test,
Michael Albinus <=
- bug#9803: [PATCH] Add ERT option to skip test, Stefan Monnier, 2013/10/21
- bug#9803: [PATCH] Add ERT option to skip test, Michael Albinus, 2013/10/21
- bug#9803: [PATCH] Add ERT option to skip test, Stefan Monnier, 2013/10/21
- bug#9803: [PATCH] Add ERT option to skip test, Michael Albinus, 2013/10/22
- bug#9803: [PATCH] Add ERT option to skip test, Michael Albinus, 2013/10/23
- bug#9803: [PATCH] Add ERT option to skip test, Michael Albinus, 2013/10/24
- bug#9803: [PATCH] Add ERT option to skip test, Glenn Morris, 2013/10/24