|
From: | Stefan Monnier |
Subject: | bug#14013: 24.3.50; dired-isearch-filenames-regexp is matching text outside filenames |
Date: | Thu, 21 Mar 2013 21:59:52 -0400 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) |
> - (pos1 (save-excursion (funcall func string bound noerror))) > + (pos1 (save-excursion > + (run-hooks 'isearch-search-fun-pre-hook) > + (funcall func string bound noerror))) Doesn't sound good. > + (add-hook 'isearch-search-fun-pre-hook 'dired-isearch-filenames-pre-hook > nil t))) Why not (add-function :around (local isearch-search-fun-function) #'dired--isearch-filenames) and then (defun dired--isearch-filenames (iiff &rest args) (let ((fun (apply iiff args))) (lambda (&rest args) (unless (get-text-property (point) 'dired-filename) (if isearch-forward (goto-char (or (next-single-property-change (point) 'dired-filename) (point-max))) (goto-char (or (previous-single-property-change (point) 'dired-filename) (point-min))))) (apply fun args)))) -- Stefan
[Prev in Thread] | Current Thread | [Next in Thread] |