[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#13831: 24.3.50; [PATCH] net-utils-mode have no revert-buffer functio
From: |
Thierry Volpiatto |
Subject: |
bug#13831: 24.3.50; [PATCH] net-utils-mode have no revert-buffer function |
Date: |
Wed, 13 Mar 2013 15:43:48 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) |
Hi Stefan,
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> Installed, thank you,
Ok thanks.
Also here something wrong also:
--8<---------------cut here---------------start------------->8---
;; Simplified versions of some at-point functions from ffap.el.
;; It's not worth loading all of ffap just for these.
(defun net-utils-machine-at-point ()
--8<---------------cut here---------------end--------------->8---
This function return not only machine but anything at point, which is
annoying.
Thus we find some lines later:
--8<---------------cut here---------------start------------->8---
(read-from-minibuffer "Lookup host: "
(or (ffap-string-at-point 'machine) ""))))
--8<---------------cut here---------------end--------------->8---
And ffap is not required.
I think actually it is not a problem loading ffap when needed:
--8<---------------cut here---------------start------------->8---
(defun net-utils-machine-at-point ()
(require 'ffap)
(ffap-machine-at-point))
(defun net-utils-url-at-point ()
(require 'ffap)
(ffap-url-at-point))
--8<---------------cut here---------------end--------------->8---
This reduce code and do the right thing.
I can send a patch if ok.
--
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
bug#13831: 24.3.50; [PATCH] net-utils-mode have no revert-buffer function, Thierry Volpiatto, 2013/03/03
bug#13831: 24.3.50; [PATCH] net-utils-mode have no revert-buffer function, Thierry Volpiatto, 2013/03/01