[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#13622: 24.3.50; doc-view: Use (and prefer) soffice as default ODF->P
From: |
Jambunathan K |
Subject: |
bug#13622: 24.3.50; doc-view: Use (and prefer) soffice as default ODF->PDF converter |
Date: |
Tue, 05 Feb 2013 16:23:56 +0530 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) |
Glenn Morris <rgm@gnu.org> writes:
> Jambunathan K wrote:
>
>> I am attaching a patch. Please apply to trunk.
>
> Some explanation as to why would be nice.
One is likely to have LibreOffice installed rather than unoconv.
Getting unoconv on non-Linux platforms could be cumbersome.
>
>> +(defcustom doc-view-odf->pdf-converter-program
>> + (cond
>> + ((executable-find "soffice") "soffice")
>> + ((executable-find "unoconv") "unoconv"))
>
> This could end up being nil, which would give a type mismatch with 'file.
>
>> :type 'file
What would you suggest? Use `choice'?
>>
>> +(defcustom doc-view-odf->pdf-converter-function
>> + (cond
>> + ((string-match "unoconv\\'" doc-view-odf->pdf-converter-program)
>> + #'doc-view-odf->pdf-converter-unoconv)
>> + ((string-match "soffice\\'" doc-view-odf->pdf-converter-program)
>> + #'doc-view-odf->pdf-converter-soffice))
>> + "Function to call to convert a ODF file into a PDF file."
>> + :type '(radio
>> + (function-item doc-view-odf->pdf-converter-unoconv
>> + :doc "Use unoconv")
>> + (function-item doc-view-odf->pdf-converter-soffice
>> + :doc "Use LibreOffice")
>> + function)
>> + :version "24.4")
>
> Why do you need this, as opposed to a single function which calls
> -program with a customizable -program-options argument?
I am mimicing what is done for recent mupdf changes.
,----
| (defcustom doc-view-pdf->png-converter-function
| (if (executable-find doc-view-pdfdraw-program)
| #'doc-view-pdf->png-converter-mupdf
| #'doc-view-pdf->png-converter-ghostscript)
| "Function to call to convert a PDF file into a PNG file."
| :type '(radio
| (function-item doc-view-pdf->png-converter-ghostscript
| :doc "Use ghostscript")
| (function-item doc-view-pdf->png-converter-mupdf
| :doc "Use mupdf")
| function)
| :version "24.4")
`----