[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#12351: 24.1; parse-colon-path turns empty paths into nil
From: |
Dave Abrahams |
Subject: |
bug#12351: 24.1; parse-colon-path turns empty paths into nil |
Date: |
Sun, 30 Dec 2012 14:53:44 -0500 |
User-agent: |
Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.2 (darwin) |
on Sun Dec 30 2012, Glenn Morris <rgm-AT-gnu.org> wrote:
> Dave Abrahams wrote:
>
>> (parse-colon-path ":") yields (nil nil) but there's nothing in the
>> docstring to indicate that empty path entries will get turned into nil.
>> Either the docstring needs to be updated, or parse-colon-path should
>> return (delq nil cd-list).
>
> Making a change equivalent to the latter has caused
>
> http://debbugs.gnu.org/13296
>
> Obviously we need the nils to remain, so I will put them back and just
> mention that empty elements return nil. It's not worth handling the
> minor aesthetic annoyance of (nil nil) specially.
FWIW, I disagree. IMO you should at least consider fixing eshell and any
other things that break because of this change. This discontinuity in
behavior is not merely aesthetic; it makes parse-colon-path difficult to
use correctly and leads to hard-to-find bugs in any code that fails to
account for the possible nils.
--
Dave Abrahams
BoostPro Computing Software Development Training
http://www.boostpro.com Clang/LLVM/EDG Compilers C++ Boost
- bug#12351: 24.1; parse-colon-path turns empty paths into nil, Glenn Morris, 2012/12/30
- bug#12351: 24.1; parse-colon-path turns empty paths into nil,
Dave Abrahams <=
- bug#12351: 24.1; parse-colon-path turns empty paths into nil, Eli Zaretskii, 2012/12/30
- bug#12351: 24.1; parse-colon-path turns empty paths into nil, Dave Abrahams, 2012/12/30
- bug#12351: 24.1; parse-colon-path turns empty paths into nil, Andreas Schwab, 2012/12/30
- bug#12351: 24.1; parse-colon-path turns empty paths into nil, Dave Abrahams, 2012/12/30
- bug#12351: 24.1; parse-colon-path turns empty paths into nil, Glenn Morris, 2012/12/31
- bug#12351: 24.1; parse-colon-path turns empty paths into nil, Dave Abrahams, 2012/12/31
- bug#12351: 24.1; parse-colon-path turns empty paths into nil, Andreas Schwab, 2012/12/31
- bug#12351: 24.1; parse-colon-path turns empty paths into nil, Wolfgang Jenkner, 2012/12/30
- bug#12351: 24.1; parse-colon-path turns empty paths into nil, Dave Abrahams, 2012/12/30
- bug#12351: 24.1; parse-colon-path turns empty paths into nil, Glenn Morris, 2012/12/31