[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#12463: 24.2; pos-visible-in-window-p gets slower over time
From: |
Stefan Monnier |
Subject: |
bug#12463: 24.2; pos-visible-in-window-p gets slower over time |
Date: |
Sat, 22 Sep 2012 16:20:56 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) |
>> >> Sorry, can't remember. Probably because I generally prefer passing
>> >> arguments explicitly over passing them via dynamic binding.
>> > We have gobs of functions in Emacs that access global variables like
>> > Vdynamic_library_alist. I don't think one more function will change
>> > anything.
>> The question is not "global or not" but "let-bound or not".
>> If it's generally accessed as a global var, that's perfectly fine.
>> If it's generally let-bound, I prefer an explicit argument.
> Sorry, I don't follow. We are discussing C code, so how do you mean
> "let-bound"? If you mean by using specbind, then no, it isn't
> let-bound, it's a global variable that always has the same value as it
> had when the last cons cell was added to it.
I'm saying: is the variable usually set once and left alone, or is it
usually let-bound around the call to the function that uses
the variable?
In the case of dynamic-library-alist it seems it's never let-bound, so
it's probably better to access it directly as a global var, rather than
pass it as a parameter.
Stefan
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, (continued)
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Chong Yidong, 2012/09/20
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Chong Yidong, 2012/09/21
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Eli Zaretskii, 2012/09/21
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Chong Yidong, 2012/09/21
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Juanma Barranquero, 2012/09/21
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Eli Zaretskii, 2012/09/21
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Stefan Monnier, 2012/09/21
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Eli Zaretskii, 2012/09/21
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Stefan Monnier, 2012/09/21
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Eli Zaretskii, 2012/09/22
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time,
Stefan Monnier <=
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Juanma Barranquero, 2012/09/22
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Chong Yidong, 2012/09/23
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Eli Zaretskii, 2012/09/22
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Juanma Barranquero, 2012/09/21
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Chong Yidong, 2012/09/21
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Eli Zaretskii, 2012/09/21
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Juanma Barranquero, 2012/09/21
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Eli Zaretskii, 2012/09/21
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Chong Yidong, 2012/09/21
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Eli Zaretskii, 2012/09/22