[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#11328: 24.1.50; Comment in `dired-copy-file-recursive' code
From: |
Thierry Volpiatto |
Subject: |
bug#11328: 24.1.50; Comment in `dired-copy-file-recursive' code |
Date: |
Thu, 26 Apr 2012 20:38:35 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) |
"Drew Adams" <drew.adams@oracle.com> writes:
> As I explained, in the particular case of NAME-CONSTRUCTOR and TARGET the
> caller
> does not in fact ever need (make use of) the _variable_ TARGET. All it needs
> is
> its value, i.e., the value at the time and place that the lambda is
> constructed,
> in `d-do-create-files'.
>
> So there is no need to include the _variable_ itself in the lambda form. It
> is
> sufficient to use its value there. That is clearer to read and is cleaner
> code.
Yes that is what i wanted to explain.
> And there is no need either to pass TARGET as an additional argument to
> `d-create-files'.
Of course there is no need to do this, it would change nothing, just
make the code clearer to use and read.
What can be done also is leave `dired-create-files' as it is and modify
`dired-do-create-files' to have a generic function usable anywhere
(actually it is usable only in dired) and easy to use; It is what I do here.
--
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
- bug#11328: 24.1.50; Comment in `dired-copy-file-recursive' code, Drew Adams, 2012/04/24
- bug#11328: 24.1.50; Comment in `dired-copy-file-recursive' code, Drew Adams, 2012/04/24
- bug#11328: 24.1.50; Comment in `dired-copy-file-recursive' code, Drew Adams, 2012/04/24
- bug#11328: 24.1.50; Comment in `dired-copy-file-recursive' code, Nix, 2012/04/25
- bug#11328: 24.1.50; Comment in `dired-copy-file-recursive' code, Drew Adams, 2012/04/25
- bug#11328: 24.1.50; Comment in `dired-copy-file-recursive' code, Thierry Volpiatto, 2012/04/25
- bug#11328: 24.1.50; Comment in `dired-copy-file-recursive' code, Drew Adams, 2012/04/25
- bug#11328: 24.1.50; Comment in `dired-copy-file-recursive' code, Thierry Volpiatto, 2012/04/26
- bug#11328: 24.1.50; Comment in `dired-copy-file-recursive' code, Drew Adams, 2012/04/26
- bug#11328: 24.1.50; Comment in `dired-copy-file-recursive' code, Drew Adams, 2012/04/26
- bug#11328: 24.1.50; Comment in `dired-copy-file-recursive' code,
Thierry Volpiatto <=
bug#11328: 24.1.50; Comment in `dired-copy-file-recursive' code, Stefan Monnier, 2012/04/24