bug#10489: 24.0.92; dired-do-copy may create infinite directory hierarchy

[Eli Zaretskii]

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: michael.albinus@gmx.de,  10489@debbugs.gnu.org,  
> thierry.volpiatto@gmail.com
> Date: Sat, 14 Jan 2012 09:19:51 -0500
> 
> To me "the same name" is something quite different from "the same file".
> I think file-name-equal-p should make it clear that it means "same name"
> and not "same file" because we may want to use it without knowing if the
> file exists and without opening a remote connection.

"Same file name" would only do case-insensitive comparison on
DOS/Windows and exact comparison otherwise.  That doesn't need to hit
the disk.

> IIUC the original problem in dired-do-copy needs to test "same file"
> rather than "same name", so it should not use file-name-equal-p but
> file-equal-p (which would rely on file-attributes, presumably).

I agree; this thread discusses file-equal-p.