bug#9185: 24.0.50; "C-s M-p" does not bring the tip of the search ring

[Dani Moncayo]

> This complicates the behavior of `M-p'.

I don't know if the underlying implementation becomes a bit more
complex, but the resulting behavior is clearly better for the user
(IMO).

> Do you propose the following logic?
>
> 1. When the user starts Isearch with `C-s', then
>   `M-p' should retrieve the _first_ entry from the search ring.

Yes. This is obviously what the average user should expect.

> 2. But when the user starts Isearch with `C-s C-s', then
>   `M-p' should retrieve the _second_ entry from the search ring.

Yes too.  In this case, when the user types `M-p', s?he should want to
get the second entry, because the first one is already in effect.
IOW, `M-p' should always retrieve the _previous_ entry from the ring,
which in this case is the second one.

> But what to do when the user starts Isearch with `C-s C-s', but
> changes his mind and deletes it from the current search string,
> i.e. types `C-s C-s DEL'.  What should `M-p' bring in this case?
> The first or the second entry?

In this case, the user has discarded the first entry and then has
typed `M-p'.  Thus, TRT for `M-p' in this case is IMO to retrieve the
second entry.

The same question is applicable to the sequence `C-s M-p
<delete_the_entry_in_the_minibuffer> M-p'.  I've just tested this and
see that the current behavior is that, i.e., the last `M-p' retrieves
the second entry (which IMO is TRT).

-- 
Dani Moncayo